Scripts enhancements #1321
Merged
Scripts enhancements #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosites
reviewed
Aug 28, 2024
populate_deploy_commits.js
Outdated
| for (const branch of branches) { | ||
| try { | ||
| const commit = execSync( | ||
| `git log -1 --format=%H ${branch} -- ${contractPath}/contracts` |
There was a problem hiding this comment.
Let's check ${contractPath}/contracts/deploys.js specifically.
|
Because |
|
Agreed - |
dmosites
approved these changes
Aug 30, 2024
smartcontrart
added a commit
that referenced
this pull request
Sep 4, 2024
* Scripts enhancements (#1321) * Added checks to validate target deployment address matches mainnet * Added storing of commit hashes upon deployment to track deployed code * Created script to populate the latest deploy commits * Renamed deploy commits script for clarity * Updated module declarations * Removed script to populate hashes * prompt language update --------- Co-authored-by: Don Mosites <[email protected]> * Bump micromatch from 4.0.5 to 4.0.8 (#1323) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 1.6.7 to 1.7.7 (#1324) Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.7. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.7...v1.7.7) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increased Delegate test coverage to 100% --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Don Mosites <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
smartcontrart
added a commit
that referenced
this pull request
Sep 10, 2024
* Scripts enhancements (#1321) * Added checks to validate target deployment address matches mainnet * Added storing of commit hashes upon deployment to track deployed code * Created script to populate the latest deploy commits * Renamed deploy commits script for clarity * Updated module declarations * Removed script to populate hashes * prompt language update --------- Co-authored-by: Don Mosites <[email protected]> * Bump micromatch from 4.0.5 to 4.0.8 (#1323) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 1.6.7 to 1.7.7 (#1324) Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.7. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.7...v1.7.7) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increased Delegate test coverage to 100% (#1325) * Fix/audit fixes (#1327) * Increased Delegate test coverage to 100% * Implemented audit fixes * Removed unused import --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Smartcontrart <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #1316